[grafana] feat(grafana): Introduce profiling container port #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
20241210_improve-profiling-of-grafana
branch
from
87c4293 to
ee8a108
Compare
In order to enable profiling using Grafana Alloy and Grafana Pyroscope currently you would need to abuse another container port or insert a dummy container to facitilitate profile collection. This is because a containerPort is matched with the annotations to enable profiling. As a workaround I am "abusing" the port :9094, as for the example I am working on it is unused. This change will make it possible to coexist with gossip-tcp and you would be able to enable profiling like this: ``` helm upgrade -n pyroscope-test --install grafana grafana/grafana \ --set env.GF_DIAGNOSTICS_PROFILING_ENABLED=true \ --set env.GF_DIAGNOSTICS_PROFILING_ADDR=0.0.0.0 \ --set env.GF_DIAGNOSTICS_PROFILING_PORT=6060 \ --set-string 'podAnnotations.profiles\.grafana\.com/cpu\.scrape=true' \ --set-string 'podAnnotations.profiles\.grafana\.com/cpu\.port=6060' \ --set-string 'podAnnotations.profiles\.grafana\.com/memory\.scrape=true' \ --set-string 'podAnnotations.profiles\.grafana\.com/memory\.port=6060' \ --set-string 'podAnnotations.profiles\.grafana\.com/goroutine\.scrape=true' \ --set-string 'podAnnotations.profiles\.grafana\.com/goroutine\.port=6060' ``` This is realted to grafana/pyroscope#3753 Signed-off-by: Christian Simon <[email protected]>
simonswine
force-pushed
the
20241210_improve-profiling-of-grafana
branch
from
ee8a108 to
16d47d1
Compare
simonswine
changed the title
simonswine
requested review from
jkroepke,
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable profiling using Grafana Alloy and Grafana Pyroscope
currently you would need to abuse another container port or insert a
dummy container to facitilitate profile collection.
This is because a containerPort is matched with the annotations to
enable profiling. As a workaround I am "abusing" the port :9094, as for
the example I am working on it is unused. This change will make it
possible to coexist with gossip-tcp and you would be able to enable
profiling like this:
This is related to grafana/pyroscope#3753